-
Notifications
You must be signed in to change notification settings - Fork 94
fix: jax reducers returning incorrect output values or lengths #3464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c5d85e3
add tests and use outlength
ikrommyd 1f74feb
rename test and skip if jax is not installed
ikrommyd 4215ef9
count and argmax should be returning integers
ikrommyd 7e681af
maybe make ak.any cpu and jax behavior match?
ikrommyd 51a0945
skip product checks with negative values
ikrommyd 9874810
segment product that deals with negative and zero values too
ikrommyd 28432d6
simplify the function
ikrommyd 6423929
my first attempt at apply_positional_corrections for jax
ikrommyd 74a788f
Merge branch 'main' into ikrommyd/jax-backend-reducers
ikrommyd bfae901
.at is better than concatenate
ikrommyd 32cf4e9
fix cases like ak.any([[0, 0], [1, 0], [2, 3, 4]]) maybe?
ikrommyd c35c7d4
fix sum and count with bools?
ikrommyd 1892261
Merge branch 'main' into ikrommyd/jax-backend-reducers
ianna 8178f4e
Merge branch 'main' into ikrommyd/jax-backend-reducers
ikrommyd 5bc2976
Merge branch 'main' into ikrommyd/jax-backend-reducers
ikrommyd bdfa953
make jax reducers return the same dtype as the numpy ones at the cost…
ikrommyd 8338000
Merge branch 'main' into ikrommyd/jax-backend-reducers
ikrommyd df106d7
add more tests
ikrommyd ace8829
Merge branch 'main' into ikrommyd/jax-backend-reducers
ikrommyd 64b0a9b
Merge branch 'main' into ikrommyd/jax-backend-reducers
ianna 7e70aa9
Merge branch 'main' into ikrommyd/jax-backend-reducers
ianna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.