Skip to content

chore: bump python version used for codecov in CI #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

MoAly98
Copy link
Collaborator

@MoAly98 MoAly98 commented Mar 12, 2025

In #515 the coverage was observed to be underestimated due to the use of xfail() to handle the issue described in #476. This reduced coverage was not observed locally (with python 3.9.7). It happens because the CI still uses python 3.8 to report coverage. This python version will be eventually deprecated, and it makes sense to not use it for code coverage anymore.

* bump python version used to generate code coverage to 3.8
* Run tests for python > 3.9 and python 3.8 separately with no coverage

Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference: replaces #520 as codecov upload was not working there for unclear reasons. See also codecov/codecov-action#1580.

@MoAly98 MoAly98 merged commit 1576a4d into scikit-hep:master Mar 12, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants