Skip to content

Support for parallelising ranking computations #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

MoAly98
Copy link
Collaborator

@MoAly98 MoAly98 commented Mar 31, 2025

Closes #442 and related to #421.

This PR is intended to introduce the infrastructure to be able to easily parallelise the production of ranking plots:

  • allow a list of parameters to be passed to the ranking function for which the ranking is computed
  • provide a utility to combine the ranking results from a list of ranking function calls
  • [maybe] provide simple support for utilising a user-provided dask client
    • write tests
    • improve docstrings and comments
  • pass parameters via CLI

Blocked by #514

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 93.71981% with 13 lines in your changes missing coverage. Please review.

Project coverage is 99.42%. Comparing base (1576a4d) to head (3a663d4).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/cabinetry/fit/__init__.py 92.07% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #530      +/-   ##
===========================================
- Coverage   100.00%   99.42%   -0.58%     
===========================================
  Files           22       23       +1     
  Lines         2096     2264     +168     
  Branches       291      320      +29     
===========================================
+ Hits          2096     2251     +155     
- Misses           0        9       +9     
- Partials         0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MoAly98 MoAly98 marked this pull request as draft March 31, 2025 09:03
@MoAly98 MoAly98 self-assigned this Mar 31, 2025
@MoAly98
Copy link
Collaborator Author

MoAly98 commented Mar 31, 2025

@alexander-held what do you think of this implementation to parallelise with a user-fed client? Tests currently fail because dask is not a dependency yet. I would diff this with #514 to see the change

@MoAly98 MoAly98 added enhancement New feature or request performance Related to performance labels Apr 1, 2025
Copy link

github-actions bot commented Apr 2, 2025

Status: Blocked ❌

Issues blocking this PR:


This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress.

@github-actions github-actions bot added the blocked Waiting for another PR/issue to be merged/closed. label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting for another PR/issue to be merged/closed. enhancement New feature or request performance Related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelization of nuisance parameter ranking
2 participants