-
Notifications
You must be signed in to change notification settings - Fork 17
build: use cmake build system in fastjet and fastjet-contrib #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
OK - the present setup builds on my mac using the following commands:
Depending on your circumstances you may need to specify I'm gonna leave it at that for now y'all can feel free to poke around on the PR with additions, etc. |
for more information, see https://pre-commit.ci
OK - cool so now it's at least compiling (but not finishing the install!) with scikit-build-core. CGAL is on in all the cases, installed via system libs. The errors I'm seeing don't make a lot of sense, so would now definitely appreciate help in getting the CI green again :D |
hmmm it would be nice to be able to browse the packages available in manylinux online. anyway leaving it here for now. more than decent progress. |
|
I'm also not sure what's up with this metadata error in the CI install. This doesn't happen locally. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Now that that particularly angry yak is shaved. Let's clean this up and ship it. :-) (after the fastjet/siscone/fastjet-contrib releases, etc.) |
This branch will be where we figure out
pip install .
andcibuildwheel
for scikit-hep/fastjet using the in-progress cmake build branches for fastjet/siscone/fastjet-contrib.I need to get the fastjet-contrib edits into a github repository so we can submodule it correctly.
Right now I have it working locally from the fastjet-contrib svn repository + patches.
At least on my laptop I can get the
scikit-hep/fastjet
extension compiling and linking.It doesn't yet function at runtime, but it's only a matter of time.
I'll send some further notifications when it's ready for a more serious look.
One thing we need to solve:
@matthewfeickert @henryiii