Skip to content

Conversation

@eduardo-rodrigues
Copy link
Member

No description provided.

@eduardo-rodrigues eduardo-rodrigues self-assigned this Oct 15, 2025
@eduardo-rodrigues eduardo-rodrigues added the enhancement New feature or request label Oct 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f5c8190) to head (f9407a4).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #282   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          339       339           
=========================================
  Hits           339       339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eduardo-rodrigues
Copy link
Member Author

Hi @nsmith-, it's "interesting" that I simply updated Mypy to run on Python 3.10 and I get the following complaint in the Pint module:

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

src/hepunits/pint.py:41: error: Incompatible return value type (got "PlainUnit", expected "Unit")  [return-value]
src/hepunits/pint.py:95: error: Returning Any from function declared to return "Quantity"  [no-any-return]
Found 2 errors in 1 file (checked 8 source files)

I can make Mypy ignore it but wonder why this is, especially that I see the types involved being fine if I type the commands involved on the prompt, checking things out. Any idea?

@nsmith-
Copy link
Member

nsmith- commented Oct 15, 2025

Yeah, my IDE's linter also flagged that and as far as I could tell its a false positive. Probably a typing bug on pint's side.

@eduardo-rodrigues
Copy link
Member Author

That makes sense. Indeed I could not reproduce it line-by-line, which is odd. Thanks a lot for the quick reply. I will proceed, then.

@eduardo-rodrigues eduardo-rodrigues merged commit 7231eac into main Oct 15, 2025
8 checks passed
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-python-3.14 branch October 15, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants