chore: [pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0
• github.com/astral-sh/ruff-pre-commit: v0.12.0 → v0.14.3
• github.com/psf/black-pre-commit-mirror: 24.10.0 → 25.9.0
• github.com/adamchainz/blacken-docs: 1.19.1 → 1.20.0
• github.com/pre-commit/mirrors-mypy: v1.13.0 → v1.18.2
• github.com/codespell-project/codespell: v2.3.0 → v2.4.1
• github.com/python-jsonschema/check-jsonschema: 0.30.0 → 0.34.1

Before Merging

For the PR Assignees:

• Summarize commit messages into a comprehensive review of the PR

* Update pre-commit hooks:
   - github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0
   - github.com/astral-sh/ruff-pre-commit: v0.12.0 → v0.14.3
   - github.com/psf/black-pre-commit-mirror: 24.10.0 → 25.9.0
   - github.com/adamchainz/blacken-docs: 1.19.1 → 1.20.0
   - github.com/pre-commit/mirrors-mypy: v1.13.0 → v1.18.2
   - github.com/codespell-project/codespell: v2.3.0 → v2.4.1
   - github.com/python-jsonschema/check-jsonschema: 0.30.0 → 0.34.1
* Apply fixes for RUF059: unused-unpacked-variable
   - c.f. https://docs.astral.sh/ruff/rules/unused-unpacked-variable/
* Apply fixes for RUF043: pytest-raises-ambiguous-pattern
   - c.f. https://docs.astral.sh/ruff/rules/pytest-raises-ambiguous-pattern/
* Add validation and test of pyhf.readxml.process_channel's ElementTree argument being
  not None.

Co-authored-by: Giordon Stark <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (239f765) to head (31b252e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2568   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          65       65           
  Lines        4190     4190           
  Branches      452      453    +1     
=======================================
  Hits         4116     4116           
  Misses         45       45           
  Partials       29       29           

Flag	Coverage Δ
contrib	98.11% <100.00%> (ø)
doctest	98.23% <100.00%> (ø)
unittests-3.10	96.42% <100.00%> (ø)
unittests-3.11	96.42% <100.00%> (ø)
unittests-3.12	96.42% <100.00%> (ø)
unittests-3.13	96.42% <100.00%> (ø)
unittests-3.9	96.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[matthewfeickert]

More typing issues:

mypy with Python 3.9.....................................................Failed
- hook id: mypy
- exit code: 1

src/pyhf/tensor/manager.py:150: error: If x = b'abc' then f"{x}" or "{}".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"{x!r}" or "{!r}".format(x). Otherwise, decode the bytes  [str-bytes-safe]
src/pyhf/tensor/manager.py:154: error: If x = b'abc' then f"{x}" or "{}".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"{x!r}" or "{!r}".format(x). Otherwise, decode the bytes  [str-bytes-safe]
src/pyhf/readxml.py:296: error: Item "None" of "Optional[Element[str]]" has no attribute "attrib"  [union-attr]
src/pyhf/readxml.py:297: error: Item "None" of "Optional[Element[str]]" has no attribute "attrib"  [union-attr]
src/pyhf/readxml.py:300: error: Item "None" of "Optional[Element[str]]" has no attribute "findall"  [union-attr]
src/pyhf/readxml.py:303: error: Item "None" of "Optional[Element[str]]" has no attribute "attrib"  [union-attr]
src/pyhf/readxml.py:305: error: Item "None" of "Optional[Element[str]]" has no attribute "findall"  [union-attr]
src/pyhf/readxml.py:462: error: Argument 1 to "process_channel" has incompatible type "ElementTree[Element[str]]"; expected "ElementTree[Optional[Element[str]]]"  [arg-type]
src/pyhf/readxml.py:470: error: Argument 1 to "process_measurements" has incompatible type "ElementTree[Element[str]]"; expected "ElementTree[Optional[Element[str]]]"  [arg-type]
Found 9 errors in 2 files (checked 72 source files)

mypy with Python 3.12....................................................Failed
- hook id: mypy
- exit code: 1

src/pyhf/tensor/manager.py:150: error: If x = b'abc' then f"{x}" or "{}".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"{x!r}" or "{!r}".format(x). Otherwise, decode the bytes  [str-bytes-safe]
src/pyhf/tensor/manager.py:154: error: If x = b'abc' then f"{x}" or "{}".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"{x!r}" or "{!r}".format(x). Otherwise, decode the bytes  [str-bytes-safe]
src/pyhf/readxml.py:296: error: Item "None" of "Element[str] | None" has no attribute "attrib"  [union-attr]
src/pyhf/readxml.py:297: error: Item "None" of "Element[str] | None" has no attribute "attrib"  [union-attr]
src/pyhf/readxml.py:300: error: Item "None" of "Element[str] | None" has no attribute "findall"  [union-attr]
src/pyhf/readxml.py:303: error: Item "None" of "Element[str] | None" has no attribute "attrib"  [union-attr]
src/pyhf/readxml.py:305: error: Item "None" of "Element[str] | None" has no attribute "findall"  [union-attr]
src/pyhf/readxml.py:462: error: Argument 1 to "process_channel" has incompatible type "ElementTree[Element[str]]"; expected "ElementTree[Element[str] | None]"  [arg-type]
src/pyhf/readxml.py:470: error: Argument 1 to "process_measurements" has incompatible type "ElementTree[Element[str]]"; expected "ElementTree[Element[str] | None]"  [arg-type]
Found 9 errors in 2 files (checked 72 source files)

[matthewfeickert]

Things are now just failing on Ruff revision requests, so this can get easily fixed up and then merged.

[matthewfeickert]

Thanks for the fixes @kratsg. I have a few questions on:

• How you feel about keeping some things with _ prefixes for maintainer readability in the future.
• If we need get_backend() calls at all if they aren't setting anything.
• Why an assert was added.