Skip to content

feat: LHEInit.fromstring #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

APN-Pucky
Copy link
Member

No description provided.

@APN-Pucky APN-Pucky changed the title add: LHEInit.fromstring feat: LHEInit.fromstring Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.73%. Comparing base (05968e4) to head (d1365e0).

Files with missing lines Patch % Lines
src/pylhe/__init__.py 95.08% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   91.87%   94.73%   +2.86%     
==========================================
  Files           2        2              
  Lines         320      323       +3     
  Branches       64       67       +3     
==========================================
+ Hits          294      306      +12     
+ Misses         17       10       -7     
+ Partials        9        7       -2     
Flag Coverage Δ
unittests-3.10 94.73% <95.08%> (+2.86%) ⬆️
unittests-3.11 94.73% <95.08%> (+2.86%) ⬆️
unittests-3.12 94.73% <95.08%> (+2.86%) ⬆️
unittests-3.13 94.73% <95.08%> (+2.86%) ⬆️
unittests-3.8 94.73% <95.08%> (+2.86%) ⬆️
unittests-3.9 94.73% <95.08%> (+2.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@APN-Pucky APN-Pucky marked this pull request as ready for review February 12, 2025 16:12
@APN-Pucky APN-Pucky force-pushed the lheinit_fromstring branch from a469956 to 5c555db Compare April 9, 2025 11:34
@APN-Pucky
Copy link
Member Author

I am not sure why the coverage decreases... The functions are the same and I added even more to the tests.

@eduardo-rodrigues
Copy link
Member

Hi @APN-Pucky, it seems it is because of the extra "branching" introduced with exceptions and if-then's. Not a huge difference. Dunnot if that's trivial for you to add some little tests similar to the one you added, where you provoke an exception, for example?

Otherwise this seems ready, nice 👍.

(I will be slow for the remainder of the week, at a workshop.)

@APN-Pucky APN-Pucky force-pushed the lheinit_fromstring branch from d1365e0 to bc60177 Compare April 9, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants