Skip to content

Fix Compatibility issue - #165

Merged
mirand863 merged 3 commits into
scikit-learn-contrib:mainfrom
pnhuy:issue-163
Apr 19, 2026
Merged

Fix Compatibility issue#165
mirand863 merged 3 commits into
scikit-learn-contrib:mainfrom
pnhuy:issue-163

Conversation

@pnhuy

@pnhuy pnhuy commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Fix #163 by inheriting from BaseEstimator, which ensures the estimator includes the required sklearn_tags.
402 passed, Required test coverage of 90% reached.

@pnhuy pnhuy changed the title Fix Compatibility #minor issue #163 Fix Compatibility issue Jan 30, 2026
@pnhuy

pnhuy commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

@mirand863, please consider my modest fix.

@mirand863 mirand863 closed this Apr 19, 2026
@mirand863 mirand863 reopened this Apr 19, 2026
@codecov-commenter

codecov-commenter commented Apr 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.20%. Comparing base (4595264) to head (a25a64c).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   96.68%   94.20%   -2.48%     
==========================================
  Files          13       24      +11     
  Lines        1268     1727     +459     
==========================================
+ Hits         1226     1627     +401     
- Misses         42      100      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mirand863
mirand863 merged commit 44fbc62 into scikit-learn-contrib:main Apr 19, 2026
11 checks passed
@mirand863

Copy link
Copy Markdown
Collaborator

Thank you so much for your contribution! I've just merged your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility issue: _IsotonicRegression class not inheriting from scikit-learn's BaseEstimator

3 participants