-
Notifications
You must be signed in to change notification settings - Fork 229
2. [MRG] Bilinear similarity #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvargas33
wants to merge
65
commits into
scikit-learn-contrib:master
Choose a base branch
from
mvargas33:feat-bilinear
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 58 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
4b7cdec
Remove 3.9 from compatibility
mvargas33 0147c0c
FIrst draft of bilinear mixin
mvargas33 ec09f59
Fix score_pairs
mvargas33 ec49397
Two implementations for score_pairs
mvargas33 2f3c3e1
Generalized toy tests
mvargas33 c21d283
Handmade tests incorporated
mvargas33 dbe2a7a
Fix identation for bilinear
ee5c5ee
Add performance test to choose between two methods for bilinear calc
9a10e06
Found an efficient way to compute Bilinear Sim for n pairs
b1edc46
Update method's descriptions
ae562e6
Following the correct testing structure
7ebc026
Fix identation
1d752f7
Add more tests. Fix 4 to 2 identation
45c9b97
Minor flake8 fix
407f910
Commented each test
80c9085
All tests have been generalized
90ac550
Fix flake8 identation
68eeda9
Minor details
c47797c
Remove 3.9 from compatibility
mvargas33 e07b11a
First draft of refactoring BaseMetricLearner and Mahalanobis Learner
8210acd
Avoid warning related to score_pairs deprecation in tests of pair_cal…
11b5df6
Minor fix
06b7131
Replaced score_pairs with pair_distance in tests
d5cb8b4
Replace score_pairs with pair_distance inb docs.
2f61e7b
Fix weird commit
9dd38aa
Fix weird commit
5f68ed2
Update classifiers to use pair_similarity
3d6450b
Updated rst docs
7bce493
Fix identation
7e6584a
Update docs of score_pairs, get_metric
0b58f45
Add deprecation Test. Fix identation
d4d3a9c
Merge branch 'master' into score-deprecation
d27bdf5
Merge branch 'score-deprecation' into feat-bilinear
78a205c
Refactor to use pair_similarity instead of score_pairs
dde3576
Add more testing. Test refactor TBD
3020110
Tests are now parametrized
2746668
Add bilinear in introduction
920e504
Minor comment on use case
7a24319
More changes to sueprvised
2f8ee76
Changes in weakly Supervised
60c88a6
Merge remote-tracking branch 'upstream/master' into score-deprecation
8c55970
Fixed changes requested 1
787a8d1
Fixed changes requested 2
e14f956
Add equivalence test, p_dist == p_score
0941a32
Fix tests and identation.
b019d85
Fixed changes requested 3
74df897
Fix identation
c62a4e7
Last requested changes
526e4ba
Merge branch 'score-deprecation' into feat-bilinear
2199724
Replaced pair_similarity for paiir_score
249e0fe
Last small detail
80f31ba
Merge branch 'score-deprecation' into feat-bilinear
8df44a4
Merge remote-tracking branch 'upstream/master' into feat-bilinear
eef13bb
Classifiers only test classifiers methods now. + Standard doctrings now.
b952af0
Work in tests. More comments. Some refactors
7cc0d5e
Learner lists for M and B learners. Separated test by kind. Mock clas…
5f6bdc2
Moved mocks to test_utils.py, then refactor test_bilinear_mixin.py
100a05d
Merge branch 'master' into feat-bilinear
3bf5eae
Resolved observations in interoduction.rst
acfd54b
Resolved all observations for supervised.rst and weakly_s.rst
69bd9fe
Spellcheck
ade34cc
Moved common test to test_base_metric.py . Refactor preprocessor test…
7cfd432
Fix docs annotations
0ac9e7a
Second chunks of annotations.
98340b0
Merge branch 'master' into feat-bilinear
perimosocordiae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.