Skip to content

Adding Principal Covariates Classification (PCovC) Code #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 4, 2025

Conversation

rvasav26
Copy link
Collaborator

@rvasav26 rvasav26 commented May 14, 2025

Adding PCovC code, examples, and testing suite. Adding a PCov base class that both PCovR and PCovC inherit from.

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--248.org.readthedocs.build/en/248/

@rvasav26 rvasav26 marked this pull request as ready for review May 14, 2025 17:39
@rvasav26 rvasav26 requested review from rosecers and ceriottm May 14, 2025 17:40
@rvasav26 rvasav26 requested a review from cajchristian May 14, 2025 18:48
@rosecers rosecers force-pushed the adding-pcovc-new branch from e302dbd to c0a16aa Compare May 14, 2025 19:57
@rvasav26 rvasav26 force-pushed the adding-pcovc-new branch from 3995e16 to df8fa2e Compare May 15, 2025 02:34
Copy link
Collaborator

@rosecers rosecers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking very good. There's some standardizing tasks I noted and a couple style/organization questions I'd like discussed before approving.

@rosecers rosecers requested a review from PicoCentauri May 16, 2025 16:41
@rvasav26 rvasav26 requested a review from rosecers May 19, 2025 18:56
Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice new feature!

I took a very quick look. Once the example is a clean Python file I can check more carefully.

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without checking the math carefully the overall design looks good.

Can you update the CHANGELOG file in the root of the repo with the addition you made. Thanks

@rvasav26 rvasav26 force-pushed the adding-pcovc-new branch from ddee0d5 to 12a2c39 Compare May 27, 2025 23:45
Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM. If @rosecers is also happy we can merge.

Copy link
Collaborator

@cajchristian cajchristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there. I think the docs still need some work, but most of my changes are nitpicky. Also, I'm not seeing the examples show up in the section navigation dropdown.

@cajchristian
Copy link
Collaborator

Should we also change the PCovR section of the landing page to something hybrid learning-esque?

@rvasav26
Copy link
Collaborator Author

rvasav26 commented May 29, 2025

We're almost there. I think the docs still need some work, but most of my changes are nitpicky. Also, I'm not seeing the examples show up in the section navigation dropdown.

Good catch - I believe it should be appearing now

Should we also change the PCovR section of the landing page to something hybrid learning-esque?

Yep, should be changed to "Hybrid Mapping Techniques"

Copy link
Collaborator

@cajchristian cajchristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything looks great. @rosecers wanna give everything a final look and we can merge?

Great job @rvasav26 leading this!!!

@rvasav26 rvasav26 merged commit 77fb4ea into main Jun 4, 2025
12 checks passed
@rvasav26 rvasav26 deleted the adding-pcovc-new branch June 4, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants