-
Notifications
You must be signed in to change notification settings - Fork 22
Adding Principal Covariates Classification (PCovC) Code #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New PR for exclusively adding PCovC code
e302dbd
to
c0a16aa
Compare
3995e16
to
df8fa2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking very good. There's some standardizing tasks I noted and a couple style/organization questions I'd like discussed before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice new feature!
I took a very quick look. Once the example is a clean Python file I can check more carefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without checking the math carefully the overall design looks good.
Can you update the CHANGELOG file in the root of the repo with the addition you made. Thanks
ddee0d5
to
12a2c39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM. If @rosecers is also happy we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there. I think the docs still need some work, but most of my changes are nitpicky. Also, I'm not seeing the examples show up in the section navigation dropdown.
Should we also change the PCovR section of the landing page to something hybrid learning-esque? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding PCovC code, examples, and testing suite. Adding a PCov base class that both PCovR and PCovC inherit from.
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--248.org.readthedocs.build/en/248/