Convert testfiles from unittest to pytests #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using pytest for testing but still the testsuite uses the unittest style. Moving it to pytest makes sense also in the light of fixing #279 as handling warnings is nice in pytest.
As this is a very monotonic job, I mostly vibecoded this with Copilot based on Sonnet 4.5. To help Copilot, I created an instruction file with some useful tricks on how to work on the repo.
Besides, I also cleaned up the tests:
np.testinginstead of concatenatingassertand numpy functionspytest.raises()we alwaysmatchagainst the specific error message to avoid test passing if a wrong error is raised.I don't expect a line by line review for this PR. What I did and I also would do for a review is to check example conversations of some tests. Copilot had especially problems with
test_kernel_pcovc.pyandtest_pcovc.py...