Fix ImportError with sklearn 1.7.0+ by replacing tosequence - #269
Open
AddyM wants to merge 1 commit into
Open
Conversation
- Remove deprecated sklearn.utils.tosequence import (removed in sklearn 1.7) - Convert steps to list at start of __init__ to handle all input types - Replace tosequence(steps) with direct list assignment - Fixes compatibility with scikit-learn >= 1.7.0 - Maintains backward compatibility with older sklearn versions - Add regression tests for list, tuple, and generator inputs - Verify steps attribute is always a list type The tosequence utility was deprecated in sklearn 1.5 and removed in 1.7. Using list() directly provides the same functionality without depending on sklearn internals. Fixes scikit-learn-contrib#267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #267
This PR resolves the
ImportError: cannot import name 'tosequence' from 'sklearn.utils'that occurs with scikit-learn >= 1.7.0.Root Cause
The
tosequenceutility function was deprecated in scikit-learn 1.5 and completely removed in version 1.7.0, breaking sklearn-pandas on import.Changes Made
In
sklearn_pandas/pipeline.py:sklearn.utils.tosequencesteps = list(steps)at the beginning ofTransformerPipeline.__init__self.steps = tosequence(steps)toself.steps = stepsIn
tests/test_pipeline.py:Why This Works
The
tosequenceutility simply converted various input types to a list. By callinglist(steps)at the start of__init__, we:tosequencezip())Testing
Test Results
Compatibility
Checklist