Always add Dynamight batch size flag to form and program call #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you get a random error regarding tensor size, which can be fixed with this parameter. Thus, I believe it should always be visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, Dynamight will fail to run such as here giving "Index tensor must have the same number of dimensions as self tensor".
The solution proposed by the author is adding a different --batchSize than the default (120 is given as an example). However this is not possible through Scipion as the option for --batchSize is only visible when "tasks" is used to continue a run. This PR makes the batch size option always visible, in the general section and with default value of 120.
Wbw,
Mikel