-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CI pre-commit action. #120
Conversation
@SimonHeybrock |
What @YooSunYoung said. As far as I'm concerned, we should switch to this action. I just installed the application in this repo. I'm happy to do it for all repos but I didn't want to do it without an explicit 'go ahead'. |
.github/workflows/ci.yml
Outdated
- run: python -m pip install -r requirements/ci.txt | ||
- run: tox -e static | ||
- uses: stefanzweifel/git-auto-commit-action@v5 | ||
- uses: pre-commit/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the latest version. Should we actually pin down to the patch version? We don't do this elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by pin down...?
And yeah, I see they 3.0.1 is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant 'down to' as a preposition. I.e., pin all parts of the version number. I think we often only pin the major and maybe minor version. But not the patch version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh like that...! Okay, then I'll get rid of .0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this doesn't work. In that case, I'm fine with using the full version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jl-wynen Apparently pre-commit
ci action doesn't work like that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #104
I updated the
ci.yml
of thecopier_template
workflow to usepre-commit
action itself.The
template
is not updated yet.TODO:
copier_template
)template
ci recipesIt was tested with
essnmx
: scipp/essnmx#12.