Use CI pre-commit action. #120
Conversation
|
@SimonHeybrock |
What @YooSunYoung said. As far as I'm concerned, we should switch to this action. I just installed the application in this repo. I'm happy to do it for all repos but I didn't want to do it without an explicit 'go ahead'. |
.github/workflows/ci.yml
Outdated
| - run: python -m pip install -r requirements/ci.txt | ||
| - run: tox -e static | ||
| - uses: stefanzweifel/git-auto-commit-action@v5 | ||
| - uses: pre-commit/[email protected] |
There was a problem hiding this comment.
Not the latest version. Should we actually pin down to the patch version? We don't do this elsewhere.
There was a problem hiding this comment.
What do you mean by pin down...?
And yeah, I see they 3.0.1 is released.
There was a problem hiding this comment.
I meant 'down to' as a preposition. I.e., pin all parts of the version number. I think we often only pin the major and maybe minor version. But not the patch version.
There was a problem hiding this comment.
Ahh like that...! Okay, then I'll get rid of .0.0
There was a problem hiding this comment.
Apparently this doesn't work. In that case, I'm fine with using the full version
There was a problem hiding this comment.
@jl-wynen Apparently pre-commit ci action doesn't work like that...
There was a problem hiding this comment.
Fixes #104
I updated the
ci.ymlof thecopier_templateworkflow to usepre-commitaction itself.The
templateis not updated yet.TODO:
copier_template)templateci recipesIt was tested with
essnmx: scipp/essnmx#12.