-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WFM example in docs #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a couple of minor comments but it seems nice : D
And one more question regarding the target audience.
If the target audience already know about WFM and just wants to know more about the WFM stitching methodology, I think it is fine as it is,
but if it is about introducing WFM stitching methodology, I think it'll be nice to add more diagrams or pictures to explain the concept instead of just showing the code. But that can be done in another time.
docs/wfm-stitching.ipynb
Outdated
"invalid_frames = True\n", | ||
"fact = 0.01\n", | ||
"while invalid_frames:\n", | ||
" print(f\"Searching for bounds: threshold={fact}\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/wfm-stitching.ipynb
Outdated
"source": [ | ||
"## Find WFM frame edges\n", | ||
"\n", | ||
"To compute the frame edges, we use one of the openings in the WFM choppers are a time,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get this sentence. Especially are a time
part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it should be "we use one of the openings in the WFM choppers at a time" ;-)
For the target audience, I wanted to link to the old notebook we have that introduces the technique. However, there are 2 things to consider.
|
Then we can add more link/general explanation later...! |
No description provided.