Skip to content

stats: multinomial shape-typing#1566

Merged
jorenham merged 3 commits into
masterfrom
stats.multinomial/shape-typing
Apr 19, 2026
Merged

stats: multinomial shape-typing#1566
jorenham merged 3 commits into
masterfrom
stats.multinomial/shape-typing

Conversation

@jorenham
Copy link
Copy Markdown
Member

@jorenham jorenham commented Apr 18, 2026

towards #406

ref: #1549 (review)

@jorenham
Copy link
Copy Markdown
Member Author

cc @Aniketsy; this turned out to be way more complex that I had hoped... And since I don't expect it to be any simpler for the other multivariate distributions, it's absolutely fine (and maybe even wise) if you don't feel like working on these multivariate distributions.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

mypy_primer results

✅ No ecosystem changes detected

@Aniketsy
Copy link
Copy Markdown
Contributor

cc @Aniketsy; this turned out to be way more complex that I had hoped... And since I don't expect it to be any simpler for the other multivariate distributions, it's absolutely fine (and maybe even wise) if you don't feel like working on these multivariate distributions.

thanks, yes i can see quite large changes, so i'll not touch these as diving into these will create extra work for the review, but i'll try to understand how it is done to have some knowledge, and maybe in near future i can touch these ...
for now i'll try to pick simple and moderate level issues 😁(is this good way to move towards perfectionist ? If not please correct me) , also please feel free to ping me if you feel any issue fits for me.

@jorenham jorenham merged commit a912f40 into master Apr 19, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants