You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cc @Aniketsy; this turned out to be way more complex that I had hoped... And since I don't expect it to be any simpler for the other multivariate distributions, it's absolutely fine (and maybe even wise) if you don't feel like working on these multivariate distributions.
cc @Aniketsy; this turned out to be way more complex that I had hoped... And since I don't expect it to be any simpler for the other multivariate distributions, it's absolutely fine (and maybe even wise) if you don't feel like working on these multivariate distributions.
thanks, yes i can see quite large changes, so i'll not touch these as diving into these will create extra work for the review, but i'll try to understand how it is done to have some knowledge, and maybe in near future i can touch these ...
for now i'll try to pick simple and moderate level issues 😁(is this good way to move towards perfectionist ? If not please correct me) , also please feel free to ping me if you feel any issue fits for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards #406
ref: #1549 (review)