♻️ reduce reliance on "fake" *._typing modules#731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to minimize the size of the "fake" type-check-only
*._typingmodules. Otherwise, users might be tempted to use them scipy-stubs grows bigger (like has happened withnumpy._typing).Some type aliases such as
Truthy,Falsy,RNG, andToRNGare nowadays also available inoptype. Some others were moved to the._typingmodules of specific subpackages if they were only used there. Some small literals that weren't used that often were inlined. The contextmanager mixins were replaced with a single one for__exit__.