fix: replace global shell variable with JIT shell detection
#336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbyrnes
reviewed
Feb 27, 2024
Contributor
jeffbyrnes
left a comment
jeffbyrnes
left a comment
There was a problem hiding this comment.
Lots of good stuff here! Thanks for the burst of energy & improvements recently 🙇🏻♂️
ghthor
force-pushed
the
fix-interaction-with-nix-develop-shell
branch
from
7e1705e to
6425b12
Compare
ghthor
force-pushed
the
fix-interaction-with-nix-develop-shell
branch
2 times, most recently
from
6ab7b56 to
3b14436
Compare
ghthor
changed the title
ghthor
changed the title
shell variable with JIT shell detection
ghthor
force-pushed
the
fix-interaction-with-nix-develop-shell
branch
from
3b14436 to
cf79fd0
Compare
jeffbyrnes
approved these changes
May 16, 2025
Contributor
jeffbyrnes
left a comment
jeffbyrnes
left a comment
There was a problem hiding this comment.
Seems good!
Is there any performance degradation?
jeffbyrnes
approved these changes
May 16, 2025
Member
Author
I have not noticed any after running this patch for many months. I found it lingering and forgot that I hadn't submitted it upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes conflicts where when direnv/nix develop activates it would unset this global
shellvariable.