feat: enable JIT detection of ls flavor #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ghthor
commented
May 16, 2025
ghthor
commented
When utilizing direnv and nix on darwin, you can enter directories and have the ls flavor change from BSD to GNU. This change fixes those cases by not caching which ls flavor we found at initialization time and instead JIT'ing which flavor we have at each execution point.
ghthor
force-pushed
the
fix-ls-shortcuts-when-directories-can-change-from-bsd-to-gnu-ls
branch
from
ab4320f to
c83c4e8
Compare
…-from-bsd-to-gnu-ls
Member
Author
|
This does reduce performance, but it is barely noticeable |
jeffbyrnes
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.