Skip to content

Conversation

@mmcrockett
Copy link
Contributor

@mmcrockett mmcrockett commented Aug 4, 2025

I have a .git directory in my $HOME for some git hooks I have but it isn't a git repo and confuses me when I open a new terminal and forget I'm in my home but I get the 'There were more than 150 changed files.' I've included how it should look with the /tmp directory. See screenshot.

ss 2025-08-04 at 12 33 52 PM

This removes the find_in_cwd_or_parent shell method in favor of just using a git command to determine. Seems simpler and more stable since it uses built-in git behaviour instead of rolling our own method.

@mmcrockett mmcrockett changed the title Use git to figure out git repo. fix: Use git to figure out git repo. Aug 4, 2025
Copy link
Contributor

@jeffbyrnes jeffbyrnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked, and indeed, this is the only use of find_in_cwd_or_parent(), so this seems like a win in terms of simplicity.

@ghthor
Copy link
Member

ghthor commented Aug 10, 2025

Thank you @mmcrockett & @jeffbyrnes

@ghthor ghthor merged commit 4695490 into scmbreeze:main Aug 10, 2025
4 checks passed
@mmcrockett mmcrockett deleted the mcrockett/bug-in-detecting-git-repo branch October 23, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants