chore: disable application publish#24
Conversation
There was a problem hiding this comment.
Lines 25 to 26 in 3bac20e
This is the key point for working with cargo-release.
And I think we can review this release flow once we reach 1.0 since it's nothing wrong to release to crates.io So that people can do cargo install percas.
|
My concern is that |
Yeah. This seems to be an internal crate and I agree to merge this patch once we exclude these crates from cargo-release configs. |
|
Weird why CI not trigger. Perhaps @andylokandy you can open a new PR with a different branch name. |
| language: Rust | ||
| message: "ambiguous import from `serde_json` crate" | ||
| note: | | ||
| reason: this import may lead to ambiguity between items imported from `variant` and `serde_json` crates. |
There was a problem hiding this comment.
IIRC we don't use jsonbb in this crate. Perhaps we can drop this rule?
There was a problem hiding this comment.
Value is vague IMO, maybe I could improve the note.
|
Continued in #25. |
2 participants
No description provided.