feat: integrate cluster mode with server#32
Merged
leiysky merged 9 commits intoscopedb:mainfrom Apr 20, 2025
Merged
Conversation
tisonkun
reviewed
Apr 20, 2025
| let server_addr = format!("http://{}/", state.server_state.server_advertise_addr()); | ||
| let addr = state | ||
| .server_state | ||
| .listen_addr() |
Contributor
There was a problem hiding this comment.
Should be advertise addr here? Since it's what the client should use.
Collaborator
Author
There was a problem hiding this comment.
There is some issues with the inferred advertise addr if the host network is complicated.
tisonkun
reviewed
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrate cluster with server.
Now we can launch a cluster by specify a
initial_peer_addrsconfig item to bootstrap, which can be a DNS name to utilize service discovery.Here's an example of 3 nodes cluster, which works perfectly on my PC.
