Skip to content

feat: provide a helm chart for percas over k8s#49

Merged
tisonkun merged 2 commits intoscopedb:mainfrom
ScopeDB-worm:helm
Apr 24, 2025
Merged

feat: provide a helm chart for percas over k8s#49
tisonkun merged 2 commits intoscopedb:mainfrom
ScopeDB-worm:helm

Conversation

@ScopeDB-worm
Copy link
Contributor

Have a try with the following command:

cd deploy/helm && make example/install

Tests and pipelines will be added in later PRs.

Signed-off-by: ScopeDB-worm <scopedbworm@gmail.com>
@ScopeDB-worm ScopeDB-worm changed the title deploy: provide a helm chart for percas over k8s feat: provide a helm chart for percas over k8s Apr 22, 2025
@tisonkun
Copy link
Contributor

Some license headers missing. Can run cargo x lint --fix to fix. Or determinate the concrete issue so I can help.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May add a simple usage doc? The PR description contains some info I see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto packaging isn't done in this PR. Hence there might not be a generally available way to use the chart now. The PR description demonstrates the way for developers to try it, which requires a bit more knowledge than common users.

Will add it after CI/CD is set up.

@ScopeDB-worm
Copy link
Contributor Author

Some license headers missing. Can run cargo x lint --fix to fix. Or determinate the concrete issue so I can help.

Seems Hawkeye didn't recognise the license header in Helm template format (e.g., what in the headless-service.yaml). I think for now the best solution is to exclude the deploy/helm from the check.

Signed-off-by: ScopeDB-worm <scopedbworm@gmail.com>
@tisonkun
Copy link
Contributor

@ScopeDB-worm Is this ready for merge now?

@ScopeDB-worm
Copy link
Contributor Author

@ScopeDB-worm Is this ready for merge now?

Yes!

@tisonkun tisonkun merged commit 652a002 into scopedb:main Apr 24, 2025
4 checks passed
@tisonkun
Copy link
Contributor

Merged. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments