feat: upgrade foyer to v0.17, fix disk statistics export#64
feat: upgrade foyer to v0.17, fix disk statistics export#64tisonkun merged 3 commits intoscopedb:mainfrom
Conversation
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Seems previous io.count with read_label and flush_label are removed?
What's the rationale of this logical difference?
Only flush label is removed since |
crates/server/src/scheduled.rs
Outdated
There was a problem hiding this comment.
@MrCroxx BTW, what does "ios" stand for? Is it guaranteed to increase monotonically?
There was a problem hiding this comment.
Otherwise, doing difference can cause usize/u64 underflow.
There was a problem hiding this comment.
Yes. It counts the IO request count. (To adopt to AWS EBS IO request count rule, it can be configured to count IO request by aligning to 128KiB.
Signed-off-by: tison <wander4096@gmail.com>
3 participants
Changes: