Skip to content

Syntax highlighting overrides #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JosephSemrai
Copy link

Description

Added .gitattributes to override language syntax highlighting for various dockerfiles that were not styled by default.

Continues #839 (to non-destructively reset branch)

Related Issue

#587, #520

Motivation and Context

Increases readability of certain files.

Screenshots (In case of UI changes):

https://i.imgur.com/I4uQ1uN.png
(example of the syntax highlighting appearing)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JosephSemrai JosephSemrai changed the base branch from master to develop December 18, 2019 07:06
Copy link
Collaborator

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look through my comments and also you are missing some files which are not being styled by GitHub, so scan complete repository and fix all those not being styled by default.

@kmehant
Copy link
Collaborator

kmehant commented Dec 19, 2019

Also, squash your commits :)

@JosephSemrai JosephSemrai force-pushed the gitattributes-syntax-highlighting branch from ca504af to 85af444 Compare December 19, 2019 04:09
@kmehant
Copy link
Collaborator

kmehant commented Dec 19, 2019

I guess that's it, make this last fix and squash once again to green this PR ;)

Remove trailing line

Add and remove exceptions

Remove hidden file overrides

Remove bowerrc

Update .gitattributes
@JosephSemrai JosephSemrai force-pushed the gitattributes-syntax-highlighting branch from 343f824 to 427969a Compare December 19, 2019 04:42
@kmehant kmehant requested a review from JaDogg December 19, 2019 04:55
@kmehant kmehant self-requested a review December 19, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants