Logger

[evantahler]

It's generally useful for your web servers to have logs!

[evantahler]

Closes #41

[scottcorgan]

Can you elaborate just a bit on your choice of vocabulary used in the api (such as appenders)?

[evantahler]

The vocabulary comes from https://github.com/nomiddlename/log4js-node. An appender is basically an output of the logger... it might be to the console (stdio), it might be to a file, it might be to some logging service. I'll bet for 90% of the use-cases for this server, logging to only console is OK.

[scottcorgan]

Just a few comments on the code.

Also, I like to take the safe approach and be explicit about default and custom configurations (from my Elm experience).

What do you think about the following APIs?

// Deafults to 'ALL' and 'console'
server.start({
  logger: true
});

// Allows you to configure to how you'd like?
server.start({
  customLogger: {
    level: 'All',
    appenders: [
      { type: 'console' }
    ]
  }
});

[scottcorgan]

Should probably only use the logger if they provide a config for it (not default to all the time)

[scottcorgan]

Go ahead and lock the dependency here to the latest current version. (I locked the dependencies recently to avoid any unknown breaking changes)

[evantahler]

I tend to prefer that logging is enabled by default... but OK!
Version locked and disabled by default :D

[scottcorgan]

Just a couple more changes. I have to be picky with this because it's used by some big projects and I don't want to break those projects.

Thanks!

[scottcorgan]

Sorry, just a couple more changes, then it's ready to merge! 🎉 . Should probably add an example here of using a logger default values.

[scottcorgan]

I think the default value for this should be false. Then we could check if it's true or an object, then attach the logger.

[lukaspj]

Any updates on this feature?

[scottcorgan]

@lukaspj can you move conversation to #41?

Thanks 👍