chore: bump typescript target to ES2015 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the target is ES5, typescript emits class inheritance code that is [incompatible with instanceof checks](https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work) in some cases. A consequence of targeting ES5 is that library consumers cannot use `instanceof` type narrowing on errors thrown by the library: ```ts try { const res = await gigya.accounts.getAccountInfo({UID}); } catch (err) { if (err instanceof GigyaError) { // unreachable when target is ES5 } } ``` Bumping the target to ES2015 resolves this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the target is ES5, typescript emits class inheritance code that is incompatible with instanceof checks in some cases.
A consequence of targeting ES5 is that library consumers cannot use
instanceoftype narrowing on errors thrown by the library:Bumping the target to ES2015 resolves this issue.