Test criterion PR run #1

scottgerring · 2025-02-25T08:36:43Z

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

CONTRIBUTING guidelines followed
Unit tests added/updated (if applicable)
Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
Changes in public API reviewed (if applicable)

Co-authored-by: Zhongyang Wu <[email protected]>

…#2696)

…-telemetry#2701)

Co-authored-by: Cijo Thomas <[email protected]>

github-actions · 2025-02-25T11:12:43Z

Benchmark for `6d1c738`

Click to view benchmark

Test	Base	PR	%
AddWithDynamicAttributes	106.6±7.56ns	106.9±8.34ns	+0.28%
AddWithDynamicAttributes_WithStringAllocation	96.9±1.12ns	86.8±1.31ns	-10.42%
AddWithInlineStaticAttributes	15.6±0.19ns	15.6±0.14ns	0.00%
AddWithStaticArray	1.6±0.02ns	1.6±0.02ns	0.00%
CreateOTelAnyValueInt	3.4±0.04ns	3.4±0.03ns	0.00%
CreateOTelAnyValueString	3.7±0.03ns	3.7±0.05ns	0.00%
CreateOTelKeyValue	5.6±0.03ns	5.6±0.03ns	0.00%
CreateOTelKey_Arc	15.3±0.34ns	15.3±0.23ns	0.00%
CreateOTelKey_Owned	14.0±0.22ns	14.0±0.23ns	0.00%
CreateOTelKey_Static	1.9±0.01ns	1.9±0.01ns	0.00%
CreateOTelValueInt	3.1±0.02ns	3.1±0.03ns	0.00%
CreateOTelValueString	3.7±0.03ns	3.7±0.03ns	0.00%
CreateOtelKeyValueArray	22.8±0.38ns	22.8±0.36ns	0.00%
CreateOtelKeyValueArrayWithMixedValueTypes	27.2±0.16ns	27.2±0.27ns	0.00%
CreateOtelKeyValueArrayWithNonStaticValues	101.0±2.02ns	105.4±1.82ns	+4.36%
CreateTupleKeyValue	1.2±0.01ns	1.2±0.02ns	0.00%
CreateTupleKeyValueArray	5.0±0.01ns	5.0±0.04ns	0.00%
NoAttributes	1.6±0.02ns	1.6±0.03ns	0.00%
context_attach/nested_cx_scope/empty_cx	53.8±0.35ns 17.7 MElem/sec	N/A	N/A
context_attach/nested_cx_scope/single_value_cx	100.2±2.30ns	N/A	N/A
context_attach/nested_cx_scope/span_cx	63.4±0.53ns 15.0 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/empty_cx	51.8±0.49ns 18.4 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/single_value_cx	166.8±722.10ns	N/A	N/A
context_attach/overlapping_cx_scope/span_cx	61.1±0.34ns 15.6 MElem/sec	N/A	N/A
context_attach/single_cx_scope/empty_cx	29.7±0.26ns 32.1 MElem/sec	N/A	N/A
context_attach/single_cx_scope/single_value_cx	44.3±0.68ns 21.5 MElem/sec	N/A	N/A
context_attach/single_cx_scope/span_cx	29.6±0.42ns 32.2 MElem/sec	N/A	N/A

github-actions · 2025-02-25T11:15:34Z

Benchmark for `6d1c738`

Click to view benchmark

Test	Base	PR	%
AddWithDynamicAttributes	106.6±7.56ns	106.9±8.34ns	+0.28%
AddWithDynamicAttributes_WithStringAllocation	96.9±1.12ns	86.8±1.31ns	-10.42%
AddWithInlineStaticAttributes	15.6±0.19ns	15.6±0.14ns	0.00%
AddWithStaticArray	1.6±0.02ns	1.6±0.02ns	0.00%
CreateOTelAnyValueInt	3.4±0.04ns	3.4±0.03ns	0.00%
CreateOTelAnyValueString	3.7±0.03ns	3.7±0.05ns	0.00%
CreateOTelKeyValue	5.6±0.03ns	5.6±0.03ns	0.00%
CreateOTelKey_Arc	15.3±0.34ns	15.3±0.23ns	0.00%
CreateOTelKey_Owned	14.0±0.22ns	14.0±0.23ns	0.00%
CreateOTelKey_Static	1.9±0.01ns	1.9±0.01ns	0.00%
CreateOTelValueInt	3.1±0.02ns	3.1±0.03ns	0.00%
CreateOTelValueString	3.7±0.03ns	3.7±0.03ns	0.00%
CreateOtelKeyValueArray	22.8±0.38ns	22.8±0.36ns	0.00%
CreateOtelKeyValueArrayWithMixedValueTypes	27.2±0.16ns	27.2±0.27ns	0.00%
CreateOtelKeyValueArrayWithNonStaticValues	101.0±2.02ns	105.4±1.82ns	+4.36%
CreateTupleKeyValue	1.2±0.01ns	1.2±0.02ns	0.00%
CreateTupleKeyValueArray	5.0±0.01ns	5.0±0.04ns	0.00%
NoAttributes	1.6±0.02ns	1.6±0.03ns	0.00%
context_attach/nested_cx_scope/empty_cx	53.8±0.35ns 17.7 MElem/sec	N/A	N/A
context_attach/nested_cx_scope/single_value_cx	100.2±2.30ns	N/A	N/A
context_attach/nested_cx_scope/span_cx	63.4±0.53ns 15.0 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/empty_cx	51.8±0.49ns 18.4 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/single_value_cx	166.8±722.10ns	N/A	N/A
context_attach/overlapping_cx_scope/span_cx	61.1±0.34ns 15.6 MElem/sec	N/A	N/A
context_attach/single_cx_scope/empty_cx	29.7±0.26ns 32.1 MElem/sec	N/A	N/A
context_attach/single_cx_scope/single_value_cx	44.3±0.68ns 21.5 MElem/sec	N/A	N/A
context_attach/single_cx_scope/span_cx	29.6±0.42ns 32.2 MElem/sec	N/A	N/A
log_no_subscriber	0.6±0.07ns	0.6±0.08ns	0.00%
noop_layer_disabled	12.4±0.18ns	14.2±0.31ns	+14.52%
noop_layer_enabled	25.5±0.43ns	25.5±0.30ns	0.00%
ot_layer_disabled	18.8±0.20ns	18.8±0.38ns	0.00%
ot_layer_enabled	193.5±1.93ns	193.0±3.06ns	-0.26%

Co-authored-by: Cijo Thomas <[email protected]>

…metry#2675) Co-authored-by: Braden Steffaniak <[email protected]> Co-authored-by: Cijo Thomas <[email protected]>

github-actions · 2025-02-26T07:06:45Z

Benchmark for `3d78292`

Click to view benchmark

Test	Base	PR	%
AddWithDynamicAttributes	113.4±7.28ns	106.8±7.63ns	-5.82%
AddWithDynamicAttributes_WithStringAllocation	86.8±0.91ns	87.3±1.18ns	+0.58%
AddWithInlineStaticAttributes	15.6±0.28ns	15.6±0.30ns	0.00%
AddWithStaticArray	1.6±0.02ns	1.6±0.02ns	0.00%
CreateOTelAnyValueInt	3.4±0.05ns	3.4±0.02ns	0.00%
CreateOTelAnyValueString	3.7±0.03ns	3.7±0.07ns	0.00%
CreateOTelKeyValue	5.6±0.03ns	5.6±0.03ns	0.00%
CreateOTelKey_Arc	15.3±0.26ns	15.3±0.23ns	0.00%
CreateOTelKey_Owned	14.0±0.21ns	14.0±0.17ns	0.00%
CreateOTelKey_Static	1.9±0.01ns	1.9±0.02ns	0.00%
CreateOTelValueInt	3.1±0.02ns	3.1±0.07ns	0.00%
CreateOTelValueString	3.7±0.03ns	3.7±0.07ns	0.00%
CreateOtelKeyValueArray	22.8±0.35ns	22.8±0.49ns	0.00%
CreateOtelKeyValueArrayWithMixedValueTypes	27.2±0.17ns	27.2±0.19ns	0.00%
CreateOtelKeyValueArrayWithNonStaticValues	102.7±1.09ns	101.1±1.19ns	-1.56%
CreateTupleKeyValue	1.2±0.01ns	1.2±0.02ns	0.00%
CreateTupleKeyValueArray	5.0±0.07ns	5.0±0.03ns	0.00%
NoAttributes	1.6±0.01ns	1.6±0.03ns	0.00%
context_attach/nested_cx_scope/empty_cx	54.5±0.29ns 17.5 MElem/sec	N/A	N/A
context_attach/nested_cx_scope/single_value_cx	100.5±1.94ns	N/A	N/A
context_attach/nested_cx_scope/span_cx	63.7±0.36ns 15.0 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/empty_cx	51.2±0.21ns 18.6 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/single_value_cx	167.1±723.69ns	N/A	N/A
context_attach/overlapping_cx_scope/span_cx	61.0±0.32ns 15.6 MElem/sec	N/A	N/A
context_attach/single_cx_scope/empty_cx	29.6±0.23ns 32.2 MElem/sec	N/A	N/A
context_attach/single_cx_scope/single_value_cx	44.4±0.43ns 21.5 MElem/sec	N/A	N/A
context_attach/single_cx_scope/span_cx	29.5±0.20ns 32.3 MElem/sec	N/A	N/A

github-actions · 2025-02-26T07:08:14Z

Benchmark for `6b173de`

Click to view benchmark

Test	Base	PR	%
AddWithDynamicAttributes	106.1±7.61ns	106.0±7.91ns	-0.09%
AddWithDynamicAttributes_WithStringAllocation	93.3±0.77ns	87.8±3.96ns	-5.89%
AddWithInlineStaticAttributes	15.6±0.22ns	15.6±0.41ns	0.00%
AddWithStaticArray	1.6±0.01ns	1.6±0.01ns	0.00%
CreateOTelAnyValueInt	3.4±0.13ns	3.4±0.05ns	0.00%
CreateOTelAnyValueString	3.7±0.04ns	3.7±0.05ns	0.00%
CreateOTelKeyValue	5.6±0.02ns	5.6±0.03ns	0.00%
CreateOTelKey_Arc	15.2±0.15ns	15.4±0.46ns	+1.32%
CreateOTelKey_Owned	14.1±0.61ns	14.1±0.29ns	0.00%
CreateOTelKey_Static	1.9±0.00ns	1.9±0.01ns	0.00%
CreateOTelValueInt	3.1±0.02ns	3.1±0.03ns	0.00%
CreateOTelValueString	3.7±0.04ns	3.8±0.15ns	+2.70%
CreateOtelKeyValueArray	22.7±0.22ns	22.9±1.19ns	+0.88%
CreateOtelKeyValueArrayWithMixedValueTypes	27.2±0.26ns	27.2±0.12ns	0.00%
CreateOtelKeyValueArrayWithNonStaticValues	105.3±2.24ns	105.9±1.17ns	+0.57%
CreateTupleKeyValue	1.2±0.01ns	1.2±0.01ns	0.00%
CreateTupleKeyValueArray	5.0±0.02ns	5.0±0.03ns	0.00%
NoAttributes	1.6±0.02ns	1.6±0.03ns	0.00%

github-actions · 2025-02-26T07:09:36Z

Benchmark for `3d78292`

Click to view benchmark

Test	Base	PR	%
AddWithDynamicAttributes	113.4±7.28ns	106.8±7.63ns	-5.82%
AddWithDynamicAttributes_WithStringAllocation	86.8±0.91ns	87.3±1.18ns	+0.58%
AddWithInlineStaticAttributes	15.6±0.28ns	15.6±0.30ns	0.00%
AddWithStaticArray	1.6±0.02ns	1.6±0.02ns	0.00%
CreateOTelAnyValueInt	3.4±0.05ns	3.4±0.02ns	0.00%
CreateOTelAnyValueString	3.7±0.03ns	3.7±0.07ns	0.00%
CreateOTelKeyValue	5.6±0.03ns	5.6±0.03ns	0.00%
CreateOTelKey_Arc	15.3±0.26ns	15.3±0.23ns	0.00%
CreateOTelKey_Owned	14.0±0.21ns	14.0±0.17ns	0.00%
CreateOTelKey_Static	1.9±0.01ns	1.9±0.02ns	0.00%
CreateOTelValueInt	3.1±0.02ns	3.1±0.07ns	0.00%
CreateOTelValueString	3.7±0.03ns	3.7±0.07ns	0.00%
CreateOtelKeyValueArray	22.8±0.35ns	22.8±0.49ns	0.00%
CreateOtelKeyValueArrayWithMixedValueTypes	27.2±0.17ns	27.2±0.19ns	0.00%
CreateOtelKeyValueArrayWithNonStaticValues	102.7±1.09ns	101.1±1.19ns	-1.56%
CreateTupleKeyValue	1.2±0.01ns	1.2±0.02ns	0.00%
CreateTupleKeyValueArray	5.0±0.07ns	5.0±0.03ns	0.00%
NoAttributes	1.6±0.01ns	1.6±0.03ns	0.00%
context_attach/nested_cx_scope/empty_cx	54.5±0.29ns 17.5 MElem/sec	N/A	N/A
context_attach/nested_cx_scope/single_value_cx	100.5±1.94ns	N/A	N/A
context_attach/nested_cx_scope/span_cx	63.7±0.36ns 15.0 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/empty_cx	51.2±0.21ns 18.6 MElem/sec	N/A	N/A
context_attach/overlapping_cx_scope/single_value_cx	167.1±723.69ns	N/A	N/A
context_attach/overlapping_cx_scope/span_cx	61.0±0.32ns 15.6 MElem/sec	N/A	N/A
context_attach/single_cx_scope/empty_cx	29.6±0.23ns 32.2 MElem/sec	N/A	N/A
context_attach/single_cx_scope/single_value_cx	44.4±0.43ns 21.5 MElem/sec	N/A	N/A
context_attach/single_cx_scope/span_cx	29.5±0.20ns 32.3 MElem/sec	N/A	N/A
log_no_subscriber	0.6±0.02ns	0.6±0.05ns	0.00%
noop_layer_disabled	12.4±0.27ns	12.4±0.17ns	0.00%
noop_layer_enabled	27.2±1.53ns	26.3±0.43ns	-3.31%
ot_layer_disabled	20.1±0.49ns	19.1±0.32ns	-4.98%
ot_layer_enabled	201.4±2.41ns	194.3±4.43ns	-3.53%

github-actions · 2025-02-26T07:11:02Z

Benchmark for `6b173de`

Click to view benchmark

Test	Base	PR	%
AddWithDynamicAttributes	106.1±7.61ns	106.0±7.91ns	-0.09%
AddWithDynamicAttributes_WithStringAllocation	93.3±0.77ns	87.8±3.96ns	-5.89%
AddWithInlineStaticAttributes	15.6±0.22ns	15.6±0.41ns	0.00%
AddWithStaticArray	1.6±0.01ns	1.6±0.01ns	0.00%
CreateOTelAnyValueInt	3.4±0.13ns	3.4±0.05ns	0.00%
CreateOTelAnyValueString	3.7±0.04ns	3.7±0.05ns	0.00%
CreateOTelKeyValue	5.6±0.02ns	5.6±0.03ns	0.00%
CreateOTelKey_Arc	15.2±0.15ns	15.4±0.46ns	+1.32%
CreateOTelKey_Owned	14.1±0.61ns	14.1±0.29ns	0.00%
CreateOTelKey_Static	1.9±0.00ns	1.9±0.01ns	0.00%
CreateOTelValueInt	3.1±0.02ns	3.1±0.03ns	0.00%
CreateOTelValueString	3.7±0.04ns	3.8±0.15ns	+2.70%
CreateOtelKeyValueArray	22.7±0.22ns	22.9±1.19ns	+0.88%
CreateOtelKeyValueArrayWithMixedValueTypes	27.2±0.26ns	27.2±0.12ns	0.00%
CreateOtelKeyValueArrayWithNonStaticValues	105.3±2.24ns	105.9±1.17ns	+0.57%
CreateTupleKeyValue	1.2±0.01ns	1.2±0.01ns	0.00%
CreateTupleKeyValueArray	5.0±0.02ns	5.0±0.03ns	0.00%
NoAttributes	1.6±0.02ns	1.6±0.03ns	0.00%
log_no_subscriber	0.6±0.01ns	0.6±0.01ns	0.00%
noop_layer_disabled	12.4±0.19ns	12.4±0.14ns	0.00%
noop_layer_enabled	25.3±0.28ns	25.3±0.25ns	0.00%
ot_layer_disabled	19.3±0.22ns	19.1±0.27ns	-1.04%
ot_layer_enabled	195.6±1.99ns	197.4±1.96ns	+0.92%

cijothomas and others added 12 commits February 21, 2025 07:07

Add Scott Gerring as an Approver (open-telemetry#2679)

cb81eb6

Co-authored-by: Zhongyang Wu <[email protected]>

Fix: BatchLogProcessor to invoke shutdown on exporter (open-telemetry…

27d364b

…#2696)

InstrumentationScope to include attributes in hash and eq check (open…

bc5e6ce

…-telemetry#2701)

Reduce various info logs to debug (open-telemetry#2700)

edab145

Fix .with_headers to support multiple k/v pairs (open-telemetry#2699)

64549d7

Co-authored-by: Cijo Thomas <[email protected]>

Add criterion PR

18d3f89

more protoc

c577a64

Try fix bench issue

5e4cd10

context attach bench only

ca1724b

fix

10f77a7

Bench opentelemetry only

a43ab8a

Run for the other dirs too

59b9826

scottgerring changed the base branch from main to chore/criterion-build-base February 25, 2025 10:37

scottgerring added 4 commits February 25, 2025 11:38

merged

72cc828

otel-otlp shouldn't have the lib disable in it

95343a1

formatting

64ea265

Allow commenting

9311459

scottgerring mentioned this pull request Feb 25, 2025

chore: Prevent libtest being added to bench builds open-telemetry/opentelemetry-rust#2705

Merged

4 tasks

scottgerring and others added 7 commits February 25, 2025 07:13

chore: Prevent libtest being added to bench builds (open-telemetry#2705)

59af7e2

ci: add pr naming workflow (open-telemetry#2698)

bfd9f31

Avoid duplicate crates (open-telemetry#2703)

81fea07

Co-authored-by: Cijo Thomas <[email protected]>

Modify batch processor test use flush instead of sleeptime (open-tele…

29eda05

…metry#2675) Co-authored-by: Braden Steffaniak <[email protected]> Co-authored-by: Cijo Thomas <[email protected]>

test: Nit improvement to Logger test logic (open-telemetry#2708)

7954252

merge

767190c

Remove bench (because Björn is adding it)

e9b77ca

scottgerring force-pushed the chore/criterion-build branch from 2457584 to e9b77ca Compare February 26, 2025 07:00

scottgerring closed this Feb 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test criterion PR run #1

Test criterion PR run #1

scottgerring commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

Test criterion PR run #1

Test criterion PR run #1

Conversation

scottgerring commented Feb 25, 2025

Changes

Merge requirement checklist

github-actions bot commented Feb 25, 2025

Benchmark for 6d1c738

github-actions bot commented Feb 25, 2025

Benchmark for 6d1c738

github-actions bot commented Feb 26, 2025

Benchmark for 3d78292

github-actions bot commented Feb 26, 2025

Benchmark for 6b173de

github-actions bot commented Feb 26, 2025

Benchmark for 3d78292

github-actions bot commented Feb 26, 2025

Benchmark for 6b173de

Benchmark for `6d1c738`

Benchmark for `6d1c738`

Benchmark for `3d78292`

Benchmark for `6b173de`

Benchmark for `3d78292`

Benchmark for `6b173de`