Skip to content

feat: Remove nom crate dependency#11

Open
scouten-adobe wants to merge 24 commits into
mainfrom
refactor-parser
Open

feat: Remove nom crate dependency#11
scouten-adobe wants to merge 24 commits into
mainfrom
refactor-parser

Conversation

@scouten-adobe
Copy link
Copy Markdown
Owner

No description provided.

@scouten-adobe scouten-adobe self-assigned this Mar 31, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 31, 2024

CodSpeed Performance Report

Merging #11 will degrade performances by 55.79%

Comparing refactor-parser (ec6bbbe) with main (db515af)

Summary

❌ 2 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main refactor-parser Change
parse sample C2PA Manifest Store 397.5 ns 840.8 ns -52.73%
simple data box 397.5 ns 899.2 ns -55.79%

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 94.36620% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.37%. Comparing base (db515af) to head (ec6bbbe).

Files with missing lines Patch % Lines
src/parser/source.rs 87.36% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   94.66%   95.37%   +0.71%     
==========================================
  Files          10        7       -3     
  Lines         506      346     -160     
==========================================
- Hits          479      330     -149     
+ Misses         27       16      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe changed the title Refactor parser feat: Remove nom crate dependency Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant