-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added new List View #866
base: main
Are you sure you want to change the base?
Conversation
I like what I see, the only problem that I see here is the "clickable functionality is useless right now. So I would remove it, or disable it for now, and in the future if we need it shouldn't be a problem to add it or re-enable it. For now, we don't have event descriptions or things like that, and I don't know if that is even the plan (it can harm the readability in the github readme file). |
It has potential, but I heard your concern. Will surely disable it for now. |
@scraly please review whenever you're free. |
@scraly |
ef91326
to
8307b59
Compare
I wanted to fix something that will take place on a separate PR for the filter component. It needs a few improvements such as:
|
YearSelector
properlyEventListEntry
component