Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new List View #866

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

HanzCEO
Copy link
Contributor

@HanzCEO HanzCEO commented Feb 8, 2024

  • Center YearSelector properly
  • EventListEntry component
    • Better UI
    • Expand details upon mouse click
  • Code quality
  • Mobile view optimization

@HanzCEO HanzCEO marked this pull request as draft February 8, 2024 23:42
@HanzCEO
Copy link
Contributor Author

HanzCEO commented Feb 9, 2024

image

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Feb 9, 2024

image
When clicked (last commit)


Screenshot 2024-02-09 074919
I plan to make this section extendable for future development.

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Feb 9, 2024

image image

Mobile support

@HanzCEO HanzCEO marked this pull request as ready for review February 9, 2024 01:09
@scraly
Copy link
Owner

scraly commented Feb 19, 2024

Strange behavior:
image

image

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Feb 21, 2024

@scraly fixed by e00732a

@jespino
Copy link
Contributor

jespino commented Mar 6, 2024

I like what I see, the only problem that I see here is the "clickable functionality is useless right now. So I would remove it, or disable it for now, and in the future if we need it shouldn't be a problem to add it or re-enable it. For now, we don't have event descriptions or things like that, and I don't know if that is even the plan (it can harm the readability in the github readme file).

@HanzCEO HanzCEO marked this pull request as draft March 12, 2024 03:47
@HanzCEO
Copy link
Contributor Author

HanzCEO commented Mar 13, 2024

I like what I see, the only problem that I see here is the "clickable functionality is useless right now. So I would remove it, or disable it for now, and in the future if we need it shouldn't be a problem to add it or re-enable it. For now, we don't have event descriptions or things like that, and I don't know if that is even the plan (it can harm the readability in the github readme file).

It has potential, but I heard your concern. Will surely disable it for now.

@HanzCEO HanzCEO marked this pull request as ready for review June 20, 2024 11:02
@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jun 20, 2024

@scraly please review whenever you're free.

@scraly
Copy link
Owner

scraly commented Jun 21, 2024

There are some bugs about this new list view
image

in this example, closed captions are not displayed and the bottom of the filter section have a bug too

You can test the filters on the current website to see the differences :)

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jun 23, 2024

@scraly
Interesting, I will definitely take a look into it.

@HanzCEO HanzCEO force-pushed the dev-new-list-view branch from ef91326 to 8307b59 Compare June 23, 2024 06:30
@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jun 23, 2024

image
Anything else that I should fix?

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jun 23, 2024

I wanted to fix something that will take place on a separate PR for the filter component. It needs a few improvements such as:

  • Bug: closing Filter would reset filters applied. There should be a button to reset filters instead.
  • Padding and line spacing looks uncanny.
  • Inputs should be more elegant according to the current design.

@HanzCEO HanzCEO mentioned this pull request Jun 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants