Improve interoperability with form2request and Scrapy Cloud support #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding naming:
_form2request
is from an earlier draft where form2request was actually used as a dependency, but I ended up going for a simpler approach, where both libraries have APIs that make it easy for them to work together, while keeping them independent. But I could not come up with a better name for the private module, so I kept that. Glad to change it.build_submission
that much either, but I could not think of something better for a function that “finds a form of the given type, maps input data to form fields by field type, and finds the submission button”.