use different timezones to run CI tests #1259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 234 234
Lines 2748 2748
=======================================
Hits 2697 2697
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gutsytechster
force-pushed
the
dateparser-fix-CI-tests
branch
2 times, most recently
from
a10e9fd to
13b563b
Compare
gutsytechster
force-pushed
the
dateparser-fix-CI-tests
branch
from
13b563b to
c2fc6ef
Compare
gutsytechster
force-pushed
the
dateparser-fix-CI-tests
branch
from
c2fc6ef to
57e09d6
Compare
The search_dates default behavior is to use UTC timezone when no overridden setting is provided, hence the test must define the expectations in UTC timezone.
gutsytechster
force-pushed
the
dateparser-fix-CI-tests
branch
from
25af3fb to
30c4bd3
Compare
Gallaecio
approved these changes
Mar 18, 2025
|
@Gallaecio yeah. The only difference between the two is that one observes DST while the other doesn't. So I kept both of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails when it runs at midnight or, in general, when a time difference causes changes in dates for UTC and non-UTC time zones.
Some tests expect the local timezone to be picked resulting in a different expectation than the actual result. The result of the
search_datesmethod picks UTC when nothing is provided in the absence of date & time.Additionally, I reckon the issue was introduced in #1111, where
datetime.datetime.utcnow().monthwas replaced withdatetime.datetime.today().month.