Allow md5hash to function in fips environments #1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many secure environments disable the
hashlib.md5
function because it is insecure, this causes the line below to fail making dateparser unusable in these environments:dateparser/dateparser/conf.py
Line 52 in 02bd2e5
This is remedied by replacing that line with
return hashlib.new("md5", "".join(keys).encode("utf-8"), usedforsecurity=False).hexdigest()
which appropriately bypasses the fips security check because dateparser is not using the md5 hash for security applications.Corresponding issue: #1258