Skip to content

Conversation

@MeggyCal
Copy link
Contributor

@MeggyCal MeggyCal commented Jan 2, 2026

When the year is not specified, the current year is used. We discovered the test failure today.

Fixes #1286.

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.60%. Comparing base (b7bb1a5) to head (bdde09a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1294   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files         235      235           
  Lines        2886     2886           
=======================================
  Hits         2788     2788           
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@bmwiedemann bmwiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that this fixes the test, even when running in year 2042.

@Gallaecio Gallaecio mentioned this pull request Jan 7, 2026
@Gallaecio
Copy link
Member

Closing and reopening so that the CI runs with #1296.

@Gallaecio Gallaecio closed this Jan 7, 2026
@Gallaecio Gallaecio reopened this Jan 7, 2026
@Gallaecio Gallaecio merged commit 6b23348 into scrapinghub:master Jan 7, 2026
20 of 25 checks passed
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail after 2025-12-31

3 participants