-
Notifications
You must be signed in to change notification settings - Fork 486
Added "mediodía" and "medianoche" spanish words #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 94.99% 94.99% +<.01%
==========================================
Files 302 302
Lines 2457 2459 +2
==========================================
+ Hits 2334 2336 +2
Misses 123 123
Continue to review full report at Codecov.
|
eLRuLL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christianfm10 please share some scripts with usage from before and after these new feature, with some examples on what kind of phrases this could be helpful. Thanks.
| }, | ||
| { | ||
| "(?:12\\s+)?medianoche": "00:00" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christianfm10 please add a trailing comma here and also an extra newline at the end of the file. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be edited directly, instead he should run the write_complete_data.py script that generates the json file from the .yaml file.
|
@christianfm10 Do you plan to continue working on this? Otherwise, would you mind if I take over? I see this only needs dealing with @eLRuLL’s feedback, maybe adding “la” to the list of words (since there is “el”), and adding tests that cover the use of those words to be ignored. |
| }, | ||
| { | ||
| "(?:12\\s+)?medianoche": "00:00" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be edited directly, instead he should run the write_complete_data.py script that generates the json file from the .yaml file.
I've added 'mediodía' and 'medianoche' spanish words and a test for both cases
This fixes #472
Before this feature:
After this feature: