Skip to content

Conversation

@noviluni
Copy link
Collaborator

@noviluni noviluni commented Sep 6, 2019

Fixes #516

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #562 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         302      302           
  Lines        2492     2492           
=======================================
  Hits         2369     2369           
  Misses        123      123
Impacted Files Coverage Δ
dateparser/data/date_translation_data/en.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8ba77...c035c9b. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #562 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   95.04%   95.06%   +0.02%     
==========================================
  Files         302      302              
  Lines        2481     2492      +11     
==========================================
+ Hits         2358     2369      +11     
  Misses        123      123
Impacted Files Coverage Δ
dateparser/data/date_translation_data/en.py 100% <ø> (ø) ⬆️
dateparser/utils/strptime.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01d0d1...794cb4d. Read the comment docs.

@noviluni noviluni requested a review from asadurski September 6, 2019 13:31
Copy link
Member

@asadurski asadurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far you added translation tests (good!). What would also be required are the tests for parsing functionality (suggestions, here: https://github.com/scrapinghub/dateparser/blob/master/tests/test_date_parser.py#L29 and here: https://github.com/scrapinghub/dateparser/blob/master/tests/test_freshness_date_parser.py#L34).
What I usually do is add exactly the cases from the issue which is closed by the PR (e.g. the cases mentioned in #516 (comment)).

@noviluni noviluni added the language language related issue/PR label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language language related issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strings with year abbreviation don't parse correctly

2 participants