Skip to content

Conversation

@pankon
Copy link

@pankon pankon commented Apr 30, 2020

…r shorthand hebrew months

Fixes #331

@pankon
Copy link
Author

pankon commented Apr 30, 2020

[https://github.com//issues/331](shorthand hebrew months don't work)

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #660 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   95.24%   95.32%   +0.07%     
==========================================
  Files         302      302              
  Lines        2526     2547      +21     
==========================================
+ Hits         2406     2428      +22     
+ Misses        120      119       -1     
Impacted Files Coverage Δ
dateparser/data/date_translation_data/he.py 100.00% <ø> (ø)
dateparser/date.py 97.97% <0.00%> (-0.04%) ⬇️
dateparser/freshness_date_parser.py 100.00% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a366e5f...92e87a6. Read the comment docs.

@noviluni noviluni added the language language related issue/PR label Apr 30, 2020
@harsh9200
Copy link

Have you seen https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data ?

You are only allowed to change the YAML data.

In your case change the required data in the following YAML file
dateparser\dateparser_data\supplementary_language_data\date_translation_data\he.yaml

And run scripts/write_complete_data.py to generate data in corresponding python files.

@pankon pankon closed this May 3, 2020
@pankon pankon reopened this May 3, 2020
@pankon
Copy link
Author

pankon commented May 3, 2020

Great to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language language related issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortened Hebrew months are not parsed

3 participants