Add a user attribute to Message #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The maintainer needs to add other maintainers to help him if he doesn't have time for it anymore. This project is an excellent project and really needs love. If he sees this, I am happy to help, just let me know. I would merge the above in, in a heartbeat. Nice work. |
|
Tried to reachout to the maintainer but got no answer. What I did was to fork the repo, created a new pypi package: slacknotng and pushed there a new version. If anybody is interested in helping maintaining this pls pm me and I can add him a maintainer in github and pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit goes to #110, but since there has been no activity to fix the PR in more than 6 months I'm submitting a similar PR.
Because of #167, it's hard to tell whether or not my change did anything wrong.
Wasn't sure about writing tests either since there doesn't seem to be tests for
get_channelwhich is similar to the newget_userin this PR, so I didn't write any.