[Issue-435] Job Argument filter for ZyteJobsComparisonMonitor#461
Merged
VMRuiz merged 10 commits intoscrapinghub:masterfrom Apr 11, 2025
Merged
[Issue-435] Job Argument filter for ZyteJobsComparisonMonitor#461VMRuiz merged 10 commits intoscrapinghub:masterfrom
VMRuiz merged 10 commits intoscrapinghub:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 79.58% 79.70% +0.12%
==========================================
Files 76 76
Lines 3242 3262 +20
Branches 321 326 +5
==========================================
+ Hits 2580 2600 +20
Misses 593 593
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fcanobrash
approved these changes
Apr 2, 2025
Contributor
fcanobrash
left a comment
fcanobrash
left a comment
There was a problem hiding this comment.
LGTM. Thanks @shafiq-muhammad!
VMRuiz
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job argument filter to get the past jobs with desired arguments is added for ZyteJobsComparisonMonitor.
SPIDERMON_JOBS_COMPARISON_ARGUMENTSsetting will be used to provide the list of desired arguments.