Skip to content

Corrected the argument in super().__init__() within SplashAwareDupeFilter's __init__() #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gallaecio merged 1 commit into from
Feb 11, 2025
Merged

Corrected the argument in super().__init__() within SplashAwareDupeFilter's __init__() #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scrapy_splash/dupefilter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
DeprecationWarning,
stacklevel=2,
)
super().__init__(path, debug, fingerprinter)
super().__init__(path, debug, fingerprinter=fingerprinter)

Check warning on line 139 in scrapy_splash/dupefilter.py

View check run for this annotation

Codecov / codecov/patch

scrapy_splash/dupefilter.py#L139 

Added line #L139 was not covered by tests

def request_fingerprint(self, request):
return splash_request_fingerprint(request)