Switch auto field stats to an item pipeline#216
Closed
Gallaecio wants to merge 10 commits intoscrapy-plugins:mainfrom
Closed
Switch auto field stats to an item pipeline#216Gallaecio wants to merge 10 commits intoscrapy-plugins:mainfrom
Gallaecio wants to merge 10 commits intoscrapy-plugins:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 97.86% 98.03% +0.16%
==========================================
Files 14 16 +2
Lines 1590 1625 +35
Branches 337 342 +5
==========================================
+ Hits 1556 1593 +37
+ Misses 14 11 -3
- Partials 20 21 +1
|
wRAR
approved these changes
Aug 27, 2024
kmike
reviewed
Aug 29, 2024
kmike
reviewed
Aug 29, 2024
Member
|
The code looks good 👍 But I haven't checked how it works, and if it solves the issue :) |
kmike
reviewed
Aug 30, 2024
| logger = getLogger(__name__) | ||
|
|
||
|
|
||
| class ScrapyZyteAPIAutoFieldStatsItemPipeline: |
Member
There was a problem hiding this comment.
Moving it to scrapy-poet might allow to make the name shorter :)
kmike
approved these changes
Aug 30, 2024
1 task
Contributor
Author
|
Closing in favor of zytedata/zyte-common-items#124. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was asked to support non-standard, custom items for auto field stats.
To achieve that, it seemed easier to switch the implementation to an item pipeline.
It also feels like this feature would make sense in scrapy-poet now. But I am not 100% sure, and I also would not want to move it until scrapy-poet gained add-on support.
To do:
setup.pyandtox.iniaccordingly.