Open
Conversation
nerevaryn
reviewed
Sep 16, 2025
| # run: >- | ||
| # python -m pip install -e . | ||
| # | ||
| # - name: Publish distribution 📦 to Private PyPI |
There was a problem hiding this comment.
this should be alright IMHO.
@ogiaquino please add Adrian and Andrey to help us reviewing this PR
wRAR
reviewed
Jan 8, 2026
There was a problem hiding this comment.
Is it intentional that there are two conftest files?
wRAR
reviewed
Jan 8, 2026
| ) | ||
|
|
||
| __all__ = [ | ||
| SPIDERMON_JOBS_COMPARISON, |
There was a problem hiding this comment.
Does this really work and pass ruff? __all__ is a list of strings
There was a problem hiding this comment.
Well, I guess it works because those constants are strings with the same values as names...
wRAR
reviewed
Jan 8, 2026
| You can also filter which jobs to compare based on their close reason using the | ||
| ``SPIDERMON_JOBS_COMPARISON_CLOSE_REASONS`` setting. The default value is ``()``, | ||
| which doesn't filter any job based on close_reason. To only consider successfully finished jobs, | ||
| use ``("finished", ) instead.`` |
There was a problem hiding this comment.
Suggested change
| use ``("finished", ) instead.`` | |
| use ``("finished", )`` instead. |
wRAR
reviewed
Jan 8, 2026
| The job that will have all the desired arguments will be processed. | ||
| Example {"debug_url": "https://www.google.com"} or {"is_full_crawl": True} | ||
| You can enable this filter by setting SPIDERMON_JOBS_COMPARISON_ARGUMENTS_ENABLED as True in the settings. | ||
| Otherwise, this filter will not be applied |
There was a problem hiding this comment.
Suggested change
| Otherwise, this filter will not be applied | |
| Otherwise, this filter will not be applied. |
wRAR
reviewed
Jan 8, 2026
| @@ -0,0 +1,13 @@ | |||
| [tox] | |||
| envlist = min,py39,py310,py311,py312 | |||
wRAR
reviewed
Jan 8, 2026
Comment on lines
+23
to
+28
| - python-version: "3.9" | ||
| tox: min | ||
| - python-version: "3.10" | ||
| - python-version: "3.11" | ||
| - python-version: "3.12" | ||
| - python-version: "3.13" |
There was a problem hiding this comment.
This doesn't match the version range declared as supported in README.rst and setup.py, and there is no min env.
wRAR
reviewed
Jan 8, 2026
Comment on lines
+11
to
+12
| quote-style = "double" | ||
| indent-style = "space" |
wRAR
reviewed
Jan 8, 2026
| @@ -0,0 +1,13 @@ | |||
| [tool.ruff] | |||
| line-length = 88 | |||
wRAR
reviewed
Jan 8, 2026
| @@ -0,0 +1,2 @@ | |||
| [bdist_wheel] | |||
| universal = 1 | |||
wRAR
reviewed
Jan 8, 2026
| long_description_content_type="text/x-rst", | ||
| license="BSD", | ||
| packages=find_packages(), | ||
| package_data={"zyte_spidermon": ["VERSION"]}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.