Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only prefix absolute URLs with / #34

Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jan 11, 2023

Alternative approach to #8 that passes the introduced test for #4 without causing the issue that lead to #24.

Closes #24.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #34 (556b810) into master (6c7c318) will increase coverage by 0.59%.
The diff coverage is 100.00%.

❗ Current head 556b810 differs from pull request most recent head 17dd86b. Consider uploading reports for the commit 17dd86b to get more accurate results

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   97.87%   98.47%   +0.59%     
==========================================
  Files           1        1              
  Lines         330      327       -3     
  Branches       83       83              
==========================================
- Hits          323      322       -1     
+ Misses          4        3       -1     
+ Partials        3        2       -1     
Files Changed Coverage Δ
src/protego.py 98.47% <100.00%> (+0.59%) ⬆️

@Gallaecio Gallaecio merged commit 741d95f into scrapy:master Aug 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant