-
Notifications
You must be signed in to change notification settings - Fork 97
feat: support cat-blocks as an optional theme #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Test report for scratch-gui 1 files - 1 45 suites - 17 46s ⏱️ - 8m 53s For more details on these failures, see this check. Results for commit a702b4f. ± Comparison against base commit 280cc00. This pull request removes 116 and adds 13 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
adzhindzhi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! It does raise some UX questions, such as how we would toggle this on/off, where it would live in the UI, and whether we'd want to use it along with the high contrast theme (likely yes), etc. But that's not something we need to figure out now.
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-416
Proposed Changes
Reason for Changes
As part of the membership initiative, we want to reintroduce the cat blocks theme as an optional theme for supporters of Scratch