chore: Sunset membership-label#10254
Open
rosics-code wants to merge 21 commits into
Open
Conversation
Removed MembershipLabel component usage for actor and recipient membership labels.
Removed 'actor_membership_label' prop from multiple message components.
Removed MembershipLabel component from RemixProjectMessage.
Removed MembershipLabel import and usage from LoveProjectMessage component.
Removed MembershipLabel component from FollowUserMessage.
Removed MembershipLabel import and usage from FavoriteProjectMessage.
Removed MembershipLabel component from curator invite message.
Removed MembershipLabel import and its usage in BecomeManagerMessage.
Removed MembershipLabel import and usage from BecomeHostMessage component.
Removed actorLabel prop type validation.
Removed actorLabel prop type validation from LoveProjectMessage.
Removed actorLabel prop type validation from RemixProjectMessage.
Contributor
Author
|
@adzhindzhi @KManolov3 What do you think |
Removed creatorMembershipLabel prop and related logic.
Remove unused LABEL_TYPE import and update Thumbnail component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
PR
Changes:
Removes
membership-labelas membership is being sunset and we may never use these again. If we do need these again, we can look at commit history.