fix(3399): Fix metadata merge logic from external pipeline BREAKING CHANGE: external meta is not fetched implicitly #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: external meta is not fetched implicitly
kumada626
force-pushed
the
fix_meta_fetch
branch
from
5a2036d to
4c6f4e2
Compare
kumada626
changed the title
y-oksaku
approved these changes
Oct 15, 2025
yk634
approved these changes
Oct 16, 2025
minghay
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As described in screwdriver-cd/screwdriver#3399, remote triggered build should not fetch metadata implicitly from upstream builds.
Therefore, we are changing the logic for fetching metadata from external builds.
When the parent build/event is an external build, the build does not implicitly fetch metadata.
It is fetched only under
meta.sd.{pipelineId}and is obtained using the--externaloption of the meta-cli.Objective
References
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.