Conversation
arybczak
force-pushed
the
lockless
branch
2 times, most recently
from
b067b6a to
e9933c6
Compare
MVar-based pool seems to exhibit horrible lock contention in specific workloads (especially with a single stripe), let's try a lockless implementation with STM. Putting resources back doesn't block now so note "signal uninterruptible" no longer applies.
Raveline
approved these changes
May 12, 2025
Raveline
left a comment
Raveline
left a comment
There was a problem hiding this comment.
Looks good to me. 🤞 (Hopefully, I didn't miss anything)
bugthunk
approved these changes
May 12, 2025
bugthunk
left a comment
bugthunk
left a comment
There was a problem hiding this comment.
My review isn't worth much ATM (I don't understand the first MVar-based pooler to begin with and my STM is a bit rusty), but you have my go-ahead to put it on staging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVar-based pool seems to exhibit horrible lock contention in specific workloads (especially with a single stripe), let's try a lockless implementation with STM.
Putting resources back doesn't block now so note "signal uninterruptible" no longer applies.