Repository navigation
feat: demo custom transitions with Motion and el.animate - #1130
Draft
tembo[bot] wants to merge 2 commits into
Draft
tembo[bot] wants to merge 2 commits into
tembo[bot] wants to merge 2 commits into
Conversation
Co-authored-by: tembo[bot] <208362400+tembo-io[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Cody <81981+stipsan@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
animate(from, to, { type: 'spring' })).#custom-transition-el-animate): a custom transition with no library.Element.animate()can't animate scroll positions, so the element scrolls instantly and its content is animated with atransformfrom where it was (FLIP). Clicking a new button mid-animation carries on smoothly.ExampleCustomTransition) and show hand-written source, so the code shown isn't minified.popmotionandstylefire, addedmotion.smooth-scroll-into-view-if-neededgoes from^1.1.33to^2.0.2(the site was still on v1).scroll-into-view-if-neededandcompute-scroll-into-view.stipsan/and now points to thescroll-into-vieworg..numberclass clashed with the highlighter's tokens.Testing
pnpm typecheckandpnpm buildpass. I also checked in Chromium that both demos animate and end with the chosen emoji centered, for each button and both inline options.