EIP:7823 Set upper bounds for MODEXP && EIP-7883: ModExp Gas Cost && … #63
Conversation
…EIP-7951: Precompile for secp256r1 Curve Support
|
|
||
| // Galileo should accept this (no 32-byte limit) | ||
| let galileo_result = galileo_run(&input, gas_limit); | ||
| assert!(galileo_result.is_ok(), "Galileo should accept base_len > 32"); |
There was a problem hiding this comment.
should we check the result is the expected value?
src/spec.rs
Outdated
| Self::FEYNMAN | | ||
| Self::Galileo => SpecId::SHANGHAI, |
There was a problem hiding this comment.
For the CLZ opcode we might run into the same "selectively enable EIP" issue as before. @greged93
But we can address this in a separate PR.
There was a problem hiding this comment.
right, I had the same thing in mind
There was a problem hiding this comment.
I don't get the issue here, is there more context for it?
There was a problem hiding this comment.
Basically once you set SpecId::OSAKA, that will enable all Osaka upgrade changes. But in our case we only want to enable some (e.g. CLZ opcode) and not others. Revm currently does not allow selectively enabling EIPs. We ran into this with 7702.
There was a problem hiding this comment.
ok, get it. I'll open a pr to enable CLZ
Co-authored-by: greg <[email protected]>
3 participants
…EIP-7951: Precompile for secp256r1 Curve Support