Skip to content

draft: cron module #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

draft: cron module #1710

wants to merge 8 commits into from

Conversation

cboh4
Copy link
Contributor

@cboh4 cboh4 commented Apr 10, 2025

No description provided.

@cboh4 cboh4 force-pushed the cron-module branch 2 times, most recently from 25b4370 to f4b586e Compare April 14, 2025 12:57
ctx.Logger().Error("Failed to execute cron message", "error", err)
// return err
}
}

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
Copy link
Contributor

@valdok valdok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed?

Comment on lines 200 to 208
for idx, msg := range execCronMsgs {
fmt.Printf("idx, msg: %+v %+v\n", idx, msg)
ctx = ctx.WithTxBytes(bytesCronMsgs[idx])
_, err := am.keeper.Execute(ctx, msg.Contract, msg.Sender, msg.Msg, msg.SentFunds, msg.CallbackSig, wasmtypes.HandleTypeExecute)
if err != nil {
ctx.Logger().Error("Failed to execute cron message", "error", err)
// return err
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this correct.
Here you execute cron messages first (before block txs).
Whereas in the enclave code cron messages are appended last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants