draft: cron module #1710
Open
draft: cron module #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboh4
requested review from
Cashmaney,
toml01,
liorbond and
valdok
as code owners
cboh4
force-pushed
the
cron-module
branch
2 times, most recently
from
25b4370 to
f4b586e
Compare
…ssages that would be executed in the next round
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ctx.Logger().Error("Failed to execute cron message", "error", err) | ||
| // return err | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
valdok
reviewed
May 28, 2025
valdok
reviewed
May 28, 2025
valdok
reviewed
May 28, 2025
x/compute/module.go
Outdated
Comment on lines
200
to
208
| for idx, msg := range execCronMsgs { | ||
| fmt.Printf("idx, msg: %+v %+v\n", idx, msg) | ||
| ctx = ctx.WithTxBytes(bytesCronMsgs[idx]) | ||
| _, err := am.keeper.Execute(ctx, msg.Contract, msg.Sender, msg.Msg, msg.SentFunds, msg.CallbackSig, wasmtypes.HandleTypeExecute) | ||
| if err != nil { | ||
| ctx.Logger().Error("Failed to execute cron message", "error", err) | ||
| // return err | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure if this correct.
Here you execute cron messages first (before block txs).
Whereas in the enclave code cron messages are appended last.
iKapitonau
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.