-
Notifications
You must be signed in to change notification settings - Fork 222
draft: cron module #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
draft: cron module #1710
Conversation
25b4370
to
f4b586e
Compare
…ssages that would be executed in the next round
ctx.Logger().Error("Failed to execute cron message", "error", err) | ||
// return err | ||
} | ||
} |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed?
x/compute/module.go
Outdated
for idx, msg := range execCronMsgs { | ||
fmt.Printf("idx, msg: %+v %+v\n", idx, msg) | ||
ctx = ctx.WithTxBytes(bytesCronMsgs[idx]) | ||
_, err := am.keeper.Execute(ctx, msg.Contract, msg.Sender, msg.Msg, msg.SentFunds, msg.CallbackSig, wasmtypes.HandleTypeExecute) | ||
if err != nil { | ||
ctx.Logger().Error("Failed to execute cron message", "error", err) | ||
// return err | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this correct.
Here you execute cron messages first (before block txs).
Whereas in the enclave code cron messages are appended last.
No description provided.